-
Notifications
You must be signed in to change notification settings - Fork 9
fix: OutOfMemoryError for FTOF and EPICS
#152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FTOF memory fixed, however, P2 fits are often bad |
OutOfMemoryError for FTOF and EPICS
fixed |
detectors/src/main/java/org/jlab/clas/timeline/timeline/epics/MYQuery.groovy
Outdated
Show resolved
Hide resolved
|
I had a similar issue and I just solved that by removing the maximum memory request (98d14b4) |
|
Step 1 runs on Slurm nodes, so we have to keep the heap allocation max under the memory request size, otherwise Slurm will kill jobs that go over the limit. Step 2 runs on the interactive node (though #290 can do it on Slurm), which we have to share with many other users, so it's wise to keep an upper limit and not hog resources. I don't know if there's a smarter way, maybe one can improve the garbage collection; we also use |
|
Thanks. I reverted my change for the memory. (c02841d) Indeed, 1.5 G was enough to run the monitoring and timeline. I had to optimize the codes. |
resolve #151
epics_xyloption inmyqueryftof_tdcadc_p1a,ftof_tdcadc_p1b, andftof_tdcadc_p2HistoUtil.zoomHistotruncates the "empty" parts of a histogram, focusing on the region with filled bins only; for a test histogram, this zoomed histogram has around 45% of the bins$TIMELINE_JAVA_OPTS_HIGHMEM, which will increase the mempool allocation (defined in this PR, but not yet used)ftof_tdcadc_p2: now that they work, we see the fits are bad